Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-2257: Vendor karpenter CRDs #5522

Merged
merged 2 commits into from
Feb 7, 2025
Merged

HOSTEDCP-2257: Vendor karpenter CRDs #5522

merged 2 commits into from
Feb 7, 2025

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Jan 31, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 31, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2025 •
edited by openshift-ci bot
Loading

@muraee: This pull request references HOSTEDCP-2257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2025
@openshift-ci openshift-ci bot added the area/ci-tooling Indicates the PR includes changes for CI or tooling label Jan 31, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Jan 31, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2025
@muraee muraee force-pushed the vendor-karpenter branch 2 times, most recently from c6d7566 to ec0321a Compare January 31, 2025 13:39
@muraee
Copy link
Contributor Author

muraee commented Jan 31, 2025

/retest-required

@muraee muraee mentioned this pull request Feb 4, 2025
Open
4 tasks
@elmiko
Copy link
Contributor

elmiko commented Feb 4, 2025

we now have the karpenter repos mirrored into openshift org, do we want to use those for importing?

or perhaps add as a followup to this as we are still configuring the local repos.

@muraee
Copy link
Contributor Author

muraee commented Feb 5, 2025

@elmiko let's do that in a followup, will also need to change the CRDs we install in the guest cluster.

@enxebre
Copy link
Member

enxebre commented Feb 6, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2025
@muraee
Copy link
Contributor Author

muraee commented Feb 6, 2025

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1bb8b1a and 2 for PR HEAD 6b633b4 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 91bb067 and 1 for PR HEAD 6b633b4 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

@muraee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2e2c715 into openshift:main Feb 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@enxebre enxebre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@muraee @openshift-ci-robot @elmiko @enxebre @openshift-merge-robot